[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ab4186fa-5a2f-4f97-9aa7-75a6c55bc142@kernel.org>
Date: Tue, 14 May 2024 09:24:56 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Xiaxi Shen <shenxiaxi26@...il.com>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-sound@...r.kernel.org
Cc: lgirdwood@...il.com, broonie@...nel.org, robh@...nel.org,
krzk+dt@...nel.org, conor+dt@...nel.org, javier.carrasco.cruz@...il.com,
skhan@...uxfoundation.org
Subject: Re: [PATCH v2] ASoC: dt-bindings: ak4104: convert to dt schema
On 14/05/2024 09:11, Xiaxi Shen wrote:
> Convert ak4104 binding to DT schema
>
> Signed-off-by: Xiaxi Shen <shenxiaxi26@...il.com>
> ---
> Changes in v2:
> - Remove subsystem maintainers
> - Wrap lines at <80
>
> Signed-off-by: Xiaxi Shen <shenxiaxi26@...il.com>
Only one SoB.
..
> +title: AK4104 S/PDIF transmitter
> +
> +allOf:
> + - $ref: dai-common.yaml#
> +
> +maintainers:
> + - Daniel Mack <github@...que.org>
> + - Xiaxi Shen <shenxiaxi26@...il.com>
> +
> +properties:
> + compatible:
> + const: asahi-kasei,ak4104
> +
> + reg:
> + description: Chip select number on the SPI bus
> + maxItems: 1
> +
> + vdd-supply:
> + description: A regulator node providing between 2.7V and 3.6V.
> +
> + reset-gpios:
> + maxItems: 1
> + description: Optional GPIO spec for the reset pin, deasserted
> + before communication starts.
> +
> +required:
> + - compatible
> + - reg
> + - vdd-supply
> +
> +additionalProperties: false
unevaluatedProperties instead, so the dai-cells will be allowed.
> +
> +examples:
> + - |
> + i2c {
Indentation looks odd here. It should start with | above. See other files.
Best regards,
Krzysztof
Powered by blists - more mailing lists