linux-kernel - Re: [PATCH] perf Documentation: clarify sysfs event names characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 13 May 2024 17:44:41 -0700
From: Ian Rogers <irogers@...gle.com>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org, Kan Liang <kan.liang@...ux.intel.com>, 
	Arnaldo Carvalho de Melo <acme@...hat.com>, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH] perf Documentation: clarify sysfs event names characters

On Mon, May 13, 2024 at 12:24 PM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> Specify that perf event names in sysfs must not contain mixed lower and
> upper case characters and that they may contain numbers, ".", "_",
> or "-" as well.
>
> Fixes: 785623ee855e ("perf Document: Sysfs event names must be lower or upper case")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Kan Liang <kan.liang@...ux.intel.com>
> Cc: Ian Rogers <irogers@...gle.com>
> Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
> Cc: linux-perf-users@...r.kernel.org

Reviewed-by: Ian Rogers <irogers@...gle.com>

Looks good to me! Thanks,
Ian

> ---
>  Documentation/ABI/testing/sysfs-bus-event_source-devices-events |   10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff -- a/Documentation/ABI/testing/sysfs-bus-event_source-devices-events b/Documentation/ABI/testing/sysfs-bus-event_source-devices-events
> --- a/Documentation/ABI/testing/sysfs-bus-event_source-devices-events
> +++ b/Documentation/ABI/testing/sysfs-bus-event_source-devices-events
> @@ -37,11 +37,13 @@ Description:        Per-pmu performance monitor
>                 performance monitoring event supported by the <pmu>. The name
>                 of the file is the name of the event.
>
> -               As performance monitoring event names are case
> -               insensitive in the perf tool, the perf tool only looks
> -               for lower or upper case event names in sysfs to avoid
> +               As performance monitoring event names are case insensitive
> +               in the perf tool, the perf tool only looks for all lower
> +               case or all upper case event names in sysfs to avoid
>                 scanning the directory. It is therefore required the
> -               name of the event here is either lower or upper case.
> +               name of the event here is either completely lower or upper
> +               case, with no mixed-case characters. Numbers, '.', '_', and
> +               '-' are also allowed.
>
>                 File contents:
>