[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240514-amiable-unequal-d4133956c80c@spud>
Date: Tue, 14 May 2024 13:29:43 +0100
From: Conor Dooley <conor@...nel.org>
To: Florian Fainelli <florian.fainelli@...adcom.com>
Cc: linux-arm-kernel@...ts.infradead.org,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>,
Jassi Brar <jassisinghbrar@...il.com>,
Bjorn Andersson <quic_bjorande@...cinc.com>,
Maximilian Luz <luzmaximilian@...il.com>,
Ard Biesheuvel <ardb@...nel.org>,
Johan Hovold <johan+linaro@...nel.org>,
"Michael S. Tsirkin" <mst@...hat.com>,
Sudeep Holla <sudeep.holla@....com>,
Conor Dooley <conor.dooley@...rochip.com>,
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
"open list:COMMON CLK FRAMEWORK" <linux-clk@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>,
Stefan Wahren <wahrenst@....net>
Subject: Re: [PATCH 1/3] mailbox: Make BCM2835_MBOX default to ARCH_BCM2835
On Mon, May 13, 2024 at 04:52:32PM -0700, Florian Fainelli wrote:
> This driver is depended on by CONFIG_FIRMWARE_RASPBERRYPI which provides
> a number of essential services, including but not limited to a Linux
> common clock framework provider. Make sure that enable
> CONFIG_ARCH_BCM2835 does enable the corresponding mailbox driver.
>
> Signed-off-by: Florian Fainelli <florian.fainelli@...adcom.com>
> ---
> drivers/mailbox/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
> index 42940108a187..2b4cde562a90 100644
> --- a/drivers/mailbox/Kconfig
> +++ b/drivers/mailbox/Kconfig
> @@ -109,6 +109,7 @@ config ALTERA_MBOX
> config BCM2835_MBOX
> tristate "BCM2835 Mailbox"
> depends on ARCH_BCM2835
> + default ARCH_BCM2835
This is just "default y", since I doubt ARCH_BCM2835 can be a module?
If so, patch 2 could also just be "default y" and I think patch 3 can
have the same logic applied to it, given you're defaulting it to a
dependency also?
Thanks,
Conor.
> help
> An implementation of the BCM2385 Mailbox. It is used to invoke
> the services of the Videocore. Say Y here if you want to use the
> --
> 2.34.1
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists