linux-kernel - RE: [PATCH bpf] bpf, docs: Fix the description of 'src' in ALU instructions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <019c01daa60b$c08873b0$41995b10$@gmail.com>
Date: Tue, 14 May 2024 08:33:55 -0600
From: dthaler1968@...glemail.com
To: "'Puranjay Mohan'" <puranjay@...nel.org>,
	"'David Vernet'" <void@...ifault.com>,
	"'Alexei Starovoitov'" <ast@...nel.org>,
	"'Daniel Borkmann'" <daniel@...earbox.net>,
	"'Andrii Nakryiko'" <andrii@...nel.org>,
	"'Martin KaFai Lau'" <martin.lau@...ux.dev>,
	"'Eduard Zingerman'" <eddyz87@...il.com>,
	"'Song Liu'" <song@...nel.org>,
	"'Yonghong Song'" <yonghong.song@...ux.dev>,
	"'John Fastabend'" <john.fastabend@...il.com>,
	"'KP Singh'" <kpsingh@...nel.org>,
	"'Stanislav Fomichev'" <sdf@...gle.com>,
	"'Hao Luo'" <haoluo@...gle.com>,
	"'Jiri Olsa'" <jolsa@...nel.org>,
	"'Jonathan Corbet'" <corbet@....net>,
	"'Dave Thaler'" <dthaler1968@...glemail.com>,
	"'Will Hawkins'" <hawkinsw@....cr>,
	<bpf@...r.kernel.org>,
	<bpf@...f.org>,
	<linux-doc@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Cc: <puranjay12@...il.com>
Subject: RE: [PATCH bpf] bpf, docs: Fix the description of 'src' in ALU instructions

Puranjay Mohan <puranjay@...nel.org> wrote: 
> An ALU instruction's source operand can be the value in the source
register or the
> 32-bit immediate value encoded in the instruction. This is controlled by
the 's' bit of
> the 'opcode'.
> 
> The current description explicitly uses the phrase 'value of the source
register'
> when defining the meaning of 'src'.
> 
> Change the description to use 'source operand' in place of 'value of the
source
> register'.
> 
> Signed-off-by: Puranjay Mohan <puranjay@...nel.org>

Acked-by: Dave Thaler <dthaler1968@...il.com>

> ---
>  Documentation/bpf/standardization/instruction-set.rst | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/bpf/standardization/instruction-set.rst
> b/Documentation/bpf/standardization/instruction-set.rst
> index a5ab00ac0b14..2e17b365388e 100644
> --- a/Documentation/bpf/standardization/instruction-set.rst
> +++ b/Documentation/bpf/standardization/instruction-set.rst
> @@ -292,8 +292,9 @@ Arithmetic instructions  ``ALU`` uses 32-bit wide
> operands while ``ALU64`` uses 64-bit wide operands for  otherwise
identical
> operations. ``ALU64`` instructions belong to the
>  base64 conformance group unless noted otherwise.
> -The 'code' field encodes the operation as below, where 'src' and 'dst'
refer -to the
> values of the source and destination registers, respectively.
> +The 'code' field encodes the operation as below, where 'src' refers to
> +the the source operand and 'dst' refers to the value of the destination
> +register.
> 
>  =====  =====  =======
> ==========================================================
>  name   code   offset   description
> --
> 2.40.1