linux-kernel - Re: [PATCH 1/1] lib: add version into /proc/allocinfo output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJuCfpGfcY9NLM2ShxBaspwzOK5=B4WFrT0cGDRwTPJMkE+wWQ@mail.gmail.com>
Date: Tue, 14 May 2024 09:33:32 -0700
From: Suren Baghdasaryan <surenb@...gle.com>
To: Pasha Tatashin <pasha.tatashin@...een.com>
Cc: akpm@...ux-foundation.org, kent.overstreet@...ux.dev, vbabka@...e.cz, 
	keescook@...omium.org, linux-mm@...ck.org, linux-fsdevel@...r.kernel.org, 
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] lib: add version into /proc/allocinfo output

On Tue, May 14, 2024 at 8:56 AM Pasha Tatashin
<pasha.tatashin@...een.com> wrote:
>
> On Tue, May 14, 2024 at 9:35 AM Suren Baghdasaryan <surenb@...glecom> wrote:
> >
> > Add version string at the beginning of /proc/allocinfo to allow later
> > format changes. Exampe output:
> >
> > > head /proc/allocinfo
> > allocinfo - version: 1.0
> >            0        0 init/main.c:1314 func:do_initcalls
> >            0        0 init/do_mounts.c:353 func:mount_nodev_root
> >            0        0 init/do_mounts.c:187 func:mount_root_generic
> >            0        0 init/do_mounts.c:158 func:do_mount_root
> >            0        0 init/initramfs.c:493 func:unpack_to_rootfs
> >            0        0 init/initramfs.c:492 func:unpack_to_rootfs
> >            0        0 init/initramfs.c:491 func:unpack_to_rootfs
> >          512        1 arch/x86/events/rapl.c:681 func:init_rapl_pmus
> >          128        1 arch/x86/events/rapl.c:571 func:rapl_cpu_online
>
> It would be also useful to add a header line:
>
> $ head /proc/allocinfo
> allocinfo - version: 1.0
> # <size> <calls> <tag>
>             0        0 init/main.c:1314 func:do_initcalls
>             0        0 init/do_mounts.c:353 func:mount_nodev_root
>             0        0 init/do_mounts.c:187 func:mount_root_generic
>             0        0 init/do_mounts.c:158 func:do_mount_root
> ...
>
> This would be the same as in /proc/slabinfo:
> $ sudo head /proc/slabinfo
> slabinfo - version: 2.1
> # name            <active_objs> <num_objs> <objsize> <objperslab>
> <pagesperslab> : tunables <limit> <batchcount> <sharedfactor> :
> slabdata <active_slabs> <num_slabs> <sharedavail>
> pid_3               2730   2730    192   42    2 : tunables    0    0
>   0 : slabdata     65     65      0
> ..

Thanks! Addressed in v2:
https://lore.kernel.org/all/20240514163128.3662251-1-surenb@google.com/

>
> Pasha