linux-kernel - [PATCH v4 3/6] nvme: multipath: Invalidate current

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240514175322.19073-4-jmeneghi@redhat.com>
Date: Tue, 14 May 2024 13:53:19 -0400
From: John Meneghini <jmeneghi@...hat.com>
To: tj@...nel.org,
	josef@...icpanda.com,
	axboe@...nel.dk,
	kbusch@...nel.org,
	hch@....de,
	sagi@...mberg.me,
	emilne@...hat.com,
	hare@...nel.org
Cc: linux-block@...r.kernel.org,
	cgroups@...r.kernel.org,
	linux-nvme@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	jmeneghi@...hat.com,
	jrani@...estorage.com,
	randyj@...estorage.com
Subject: [PATCH v4 3/6] nvme: multipath: Invalidate current_path when changing iopolicy

From: "Ewan D. Milne" <emilne@...hat.com>

When switching back to numa from round-robin, current_path may refer to
a different path than the one numa would have selected, and it is desirable
to have consistent behavior.

Tested-by: John Meneghini <jmeneghi@...hat.com>
Signed-off-by: Ewan D. Milne <emilne@...hat.com>
Reviewed-by: Christoph Hellwig <hch@....de>
---
 drivers/nvme/host/multipath.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c
index 1e9338543ded..8702a40a1971 100644
--- a/drivers/nvme/host/multipath.c
+++ b/drivers/nvme/host/multipath.c
@@ -861,6 +861,7 @@ void nvme_subsys_iopolicy_update(struct nvme_subsystem *subsys, int iopolicy)
 	mutex_lock(&nvme_subsystems_lock);
 	list_for_each_entry(ctrl, &subsys->ctrls, subsys_entry) {
 		atomic_set(&ctrl->nr_active, 0);
+		nvme_mpath_clear_ctrl_paths(ctrl);
 	}
 	mutex_unlock(&nvme_subsystems_lock);
 }
-- 
2.39.3