linux-kernel - Re: [PATCH] tools/memory-model: Add atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 14 May 2024 12:02:40 -0700
From: "Paul E. McKenney" <paulmck@...nel.org>
To: Andrea Parri <parri.andrea@...il.com>
Cc: Puranjay Mohan <puranjay@...nel.org>,
	Alan Stern <stern@...land.harvard.edu>,
	Will Deacon <will@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Boqun Feng <boqun.feng@...il.com>,
	Nicholas Piggin <npiggin@...il.com>,
	David Howells <dhowells@...hat.com>,
	Jade Alglave <j.alglave@....ac.uk>,
	Luc Maranget <luc.maranget@...ia.fr>,
	Akira Yokosawa <akiyks@...il.com>,
	Daniel Lustig <dlustig@...dia.com>,
	Joel Fernandes <joel@...lfernandes.org>,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	puranjay12@...il.com
Subject: Re: [PATCH] tools/memory-model: Add atomic_andnot() with its variants

On Tue, May 14, 2024 at 01:11:22PM +0200, Andrea Parri wrote:
> > C andnot
> > 
> > {
> > atomic_t u = ATOMIC_INIT(7);
> > }
> > 
> > P0(atomic_t *u)
> > {
> > 
> >         r0 = atomic_fetch_andnot(3, u);
> >         r1 = READ_ONCE(*u);
> > }
> > 
> > exists (0:r0=7 /\ 0:r1=4)
> 
> Fair enough for the changelog.  If/when submitting proper tests, please
> check their format using klitmus7 (besides herd7); say,
> 
>   $ mkdir mymodule
>   $ klitmus7 -o mymodule <.litmus file>
>   $ cd mymodule ; make
>   $ sudo sh run.sh
> 
> Documentation/litmus-tests/ provides some examples litmus tests.
> 
> 
> > Signed-off-by: Puranjay Mohan <puranjay@...nel.org>
> 
> Acked-by: Andrea Parri <parri.andrea@...il.com>

Queued and pushed, thank you both!

Again, I will hold off pushing this until herd7 releases a version
supporting this.

							Thanx, Paul