linux-kernel - Re: [PATCH v2 6/8] riscv: Enable memory hotplugging for RISC-V

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f6b0577-51af-4fdf-a46a-d50787346150@redhat.com>
Date: Tue, 14 May 2024 22:40:27 +0200
From: David Hildenbrand <david@...hat.com>
To: Björn Töpel <bjorn@...nel.org>,
 Alexandre Ghiti <alexghiti@...osinc.com>
Cc: Albert Ou <aou@...s.berkeley.edu>, Palmer Dabbelt <palmer@...belt.com>,
 Paul Walmsley <paul.walmsley@...ive.com>, linux-riscv@...ts.infradead.org,
 Björn Töpel <bjorn@...osinc.com>,
 Andrew Bresticker <abrestic@...osinc.com>,
 Chethan Seshadri <Chethan.Seshadri@...alinasystems.io>,
 Lorenzo Stoakes <lstoakes@...il.com>, Oscar Salvador <osalvador@...e.de>,
 Santosh Mamila <santosh.mamila@...alinasystems.io>,
 Sivakumar Munnangi <siva.munnangi@...alinasystems.io>,
 Sunil V L <sunilvl@...tanamicro.com>, linux-kernel@...r.kernel.org,
 linux-mm@...ck.org, virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH v2 6/8] riscv: Enable memory hotplugging for RISC-V

On 14.05.24 20:17, Björn Töpel wrote:
> Alexandre Ghiti <alexghiti@...osinc.com> writes:
> 
>> On Tue, May 14, 2024 at 4:05 PM Björn Töpel <bjorn@...nel.org> wrote:
>>>
>>> From: Björn Töpel <bjorn@...osinc.com>
>>>
>>> Enable ARCH_ENABLE_MEMORY_HOTPLUG and ARCH_ENABLE_MEMORY_HOTREMOVE for
>>> RISC-V.
>>>
>>> Signed-off-by: Björn Töpel <bjorn@...osinc.com>
>>> ---
>>>   arch/riscv/Kconfig | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
>>> index 6bec1bce6586..b9398b64bb69 100644
>>> --- a/arch/riscv/Kconfig
>>> +++ b/arch/riscv/Kconfig
>>> @@ -16,6 +16,8 @@ config RISCV
>>>          select ACPI_REDUCED_HARDWARE_ONLY if ACPI
>>>          select ARCH_DMA_DEFAULT_COHERENT
>>>          select ARCH_ENABLE_HUGEPAGE_MIGRATION if HUGETLB_PAGE && MIGRATION
>>> +       select ARCH_ENABLE_MEMORY_HOTPLUG if SPARSEMEM && 64BIT && MMU
>>
>> I think this should be SPARSEMEM_VMEMMAP here.
> 
> Hmm, care to elaborate? I thought that was optional.

There was a discussion at LSF/MM today to maybe require 
SPARSEMEM_VMEMMAP for hotplug. Would that work here as well?

-- 
Cheers,

David / dhildenb