linux-kernel - Re: [PATCH] ARM: Fix userspace enter on LPAE with CC_OPTIMIZE_FOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8ef97b5d-2053-4051-b2da-6c2887c7b394@broadcom.com>
Date: Wed, 15 May 2024 12:46:38 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Geert Uytterhoeven <geert+renesas@...der.be>,
 Russell King <linux@...linux.org.uk>,
 Linus Walleij <linus.walleij@...aro.org>,
 Catalin Marinas <catalin.marinas@....com>, Kees Cook
 <keescook@...omium.org>, Russell King <rmk+kernel@...linux.org.uk>,
 Ard Biesheuvel <ardb@...nel.org>, Arnd Bergmann <arnd@...db.de>,
 Stefan Wahren <wahrenst@....net>
Cc: linux-arm-kernel@...ts.infradead.org, linux-renesas-soc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: Fix userspace enter on LPAE with
 CC_OPTIMIZE_FOR_SIZE=y

On 5/15/24 07:02, Geert Uytterhoeven wrote:
> Booting an LPAE-enabled kernel built with CONFIG_CC_OPTIMIZE_FOR_SIZE=y
> fails when starting userspace:
> 
>      Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000004
>      CPU: 1 PID: 1 Comm: init Tainted: G        W        N 6.9.0-rc1-koelsch-00004-g7af5b901e847 #1930
>      Hardware name: Generic R-Car Gen2 (Flattened Device Tree)
>      Call trace:
>       unwind_backtrace from show_stack+0x10/0x14
>       show_stack from dump_stack_lvl+0x78/0xa8
>       dump_stack_lvl from panic+0x118/0x398
>       panic from do_exit+0x1ec/0x938
>       do_exit from sys_exit_group+0x0/0x10
>      ---[ end Kernel panic - not syncing: Attempted to kill init!  exitcode=0x00000004 ]---
> 
> Add the missing memory clobber to cpu_set_ttbcr(), as suggested by
> Russell King.
> 
> Force inlining of uaccess_save_and_enable(), as suggested by Ard
> Biesheuvel.
> 
> The latter fixes booting on Koelsch.
> 
> Fixes: 7af5b901e84743c6 ("ARM: 9358/2: Implement PAN for LPAE by TTBR0 page table walks disablement")
> Closes: https://lore.kernel.org/r/CAMuHMdWTAJcZ9BReWNhpmsgkOzQxLNb5OhNYxzxv6D5TSh2fwQ@mail.gmail.com/
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Tested-by: Florian Fainelli <florian.fainelli@...adcom.com>
-- 
Florian


Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)