linux-kernel - Re: [PATCH v3] Bluetooth: btnxpuart: Enable status prints for firmware download

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <AS4PR04MB969212EDE791409746028506E7EC2@AS4PR04MB9692.eurprd04.prod.outlook.com>
Date: Wed, 15 May 2024 07:18:10 +0000
From: Neeraj Sanjay Kale <neeraj.sanjaykale@....com>
To: Paul Menzel <pmenzel@...gen.mpg.de>
CC: "marcel@...tmann.org" <marcel@...tmann.org>, "luiz.dentz@...il.com"
	<luiz.dentz@...il.com>, "linux-bluetooth@...r.kernel.org"
	<linux-bluetooth@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Amitkumar Karwar <amitkumar.karwar@....com>,
	Rohit Fule <rohit.fule@....com>, Sherry Sun <sherry.sun@....com>, Luke Wang
	<ziniu.wang_1@....com>, Bough Chen <haibo.chen@....com>, LnxRevLi
	<LnxRevLi@....com>, Guillaume Legoupil <guillaume.legoupil@....com>, Salim
 Chebbo <salim.chebbo@....com>
Subject: Re: [PATCH v3] Bluetooth: btnxpuart: Enable status prints for
 firmware download

Hi Paul,

Thank you for reviewing this patch.

> Am 14.05.24 um 11:14 schrieb Neeraj Sanjay Kale:
> > This enables prints for firmware download which can help automation
> > tests to verify firmware download functionality.
> 
> Please paste the old and new log messages to the commit message.
> 
> > A new flag BTNXPUART_FW_DOWNLOAD_ABORT is added which handles
> the
> > situation where driver is removed while firmware download is in
> > progress.
> 
> Could this be a separate patch?
> 
> > This also adds a check before freeing the rx->skb in flush and close
> > functions to handle the kernel crash seen in case of firmware download
> > timeout.
> 
> Please make this a separate commit with a Fixes: tag.
> 

I have split this patch into a 3-commit patch series and sent for review today. Please let me know your feedback on it.

We can ignore/discard this patch now.

Thanks,
Neeraj