linux-kernel - Re: [PATCH 6.6.y] kselftest: Add a ksft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 15 May 2024 09:26:37 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Edward Liaw <edliaw@...gle.com>
Cc: stable@...r.kernel.org, Shuah Khan <shuah@...nel.org>,
	kernel-team@...roid.com, Mark Brown <broonie@...nel.org>,
	Kees Cook <keescook@...omium.org>,
	Shuah Khan <skhan@...uxfoundation.org>,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6.6.y] kselftest: Add a ksft_perror() helper

On Tue, Apr 30, 2024 at 10:29:43AM -0700, Edward Liaw wrote:
> On Tue, Apr 30, 2024 at 12:51 AM Greg KH <gregkh@...uxfoundation.org> wrote:
> >
> > On Tue, Apr 30, 2024 at 01:06:27AM +0000, Edward Liaw wrote:
> > > From: Mark Brown <broonie@...nel.org>
> > >
> > > [ Upstream commit 907f33028871fa7c9a3db1efd467b78ef82cce20 ]
> > >
> > > The standard library perror() function provides a convenient way to print
> > > an error message based on the current errno but this doesn't play nicely
> > > with KTAP output. Provide a helper which does an equivalent thing in a KTAP
> > > compatible format.
> > >
> > > nolibc doesn't have a strerror() and adding the table of strings required
> > > doesn't seem like a good fit for what it's trying to do so when we're using
> > > that only print the errno.
> > >
> > > Signed-off-by: Mark Brown <broonie@...nel.org>
> > > Reviewed-by: Kees Cook <keescook@...omium.org>
> > > Signed-off-by: Shuah Khan <skhan@...uxfoundation.org>
> > > Stable-dep-of: 071af0c9e582 ("selftests: timers: Convert posix_timers test to generate KTAP output")
> > > Signed-off-by: Edward Liaw <edliaw@...gle.com>
> > > ---
> > >  tools/testing/selftests/kselftest.h | 14 ++++++++++++++
> > >  1 file changed, 14 insertions(+)
> >
> > This commit is already in 6.6.29, why submit it again?
> 
> Hi Greg,
> I double checked and I don't see this commit in 6.6.29.   As far as I
> can tell the earliest it has been merged is in 6.7.1.  Do you mind
> rechecking?

My fault, yes, you are right, it is not in 6.6.y, I don't know what I
was looking at.

Can you resubmit it if it really is needed there?

thanks,

greg k-h