linux-kernel - Re: [PATCH 1/3] mailbox: Make BCM2835_MBOX default to ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240515-reporter-audacious-d06b1009dd52@wendy>
Date: Wed, 15 May 2024 08:54:50 +0100
From: Conor Dooley <conor.dooley@...rochip.com>
To: Florian Fainelli <florian.fainelli@...adcom.com>
CC: Conor Dooley <conor@...nel.org>, <linux-arm-kernel@...ts.infradead.org>,
	Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>,
	Jassi Brar <jassisinghbrar@...il.com>, Bjorn Andersson
	<quic_bjorande@...cinc.com>, Maximilian Luz <luzmaximilian@...il.com>, Ard
 Biesheuvel <ardb@...nel.org>, Johan Hovold <johan+linaro@...nel.org>,
	"Michael S. Tsirkin" <mst@...hat.com>, Sudeep Holla <sudeep.holla@....com>,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, "open list:COMMON CLK
 FRAMEWORK" <linux-clk@...r.kernel.org>, open list
	<linux-kernel@...r.kernel.org>, Stefan Wahren <wahrenst@....net>
Subject: Re: [PATCH 1/3] mailbox: Make BCM2835_MBOX default to ARCH_BCM2835

On Tue, May 14, 2024 at 09:20:06AM -0700, Florian Fainelli wrote:
> On 5/14/24 05:29, Conor Dooley wrote:
> > On Mon, May 13, 2024 at 04:52:32PM -0700, Florian Fainelli wrote:
> > > This driver is depended on by CONFIG_FIRMWARE_RASPBERRYPI which provides
> > > a number of essential services, including but not limited to a Linux
> > > common clock framework provider. Make sure that enable
> > > CONFIG_ARCH_BCM2835 does enable the corresponding mailbox driver.
> > > 
> > > Signed-off-by: Florian Fainelli <florian.fainelli@...adcom.com>
> > > ---
> > >   drivers/mailbox/Kconfig | 1 +
> > >   1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
> > > index 42940108a187..2b4cde562a90 100644
> > > --- a/drivers/mailbox/Kconfig
> > > +++ b/drivers/mailbox/Kconfig
> > > @@ -109,6 +109,7 @@ config ALTERA_MBOX
> > >   config BCM2835_MBOX
> > >   	tristate "BCM2835 Mailbox"
> > >   	depends on ARCH_BCM2835
> > > +	default ARCH_BCM2835
> > 
> > This is just "default y", since I doubt ARCH_BCM2835 can be a module?
> 
> Right, although I intend to also add COMPILE_TEST, by then, it might be
> preferable to have it "default ARCH_BCM2835".

I'm not sure what COMPILE_TEST would have to do with the default,
the default shouldn't be important there, right?

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)