linux-kernel - Re: [RFC][PATCH 10/10] sched/eevdf: Use sched_attr::sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240515101305.GG40213@noisy.programming.kicks-ass.net>
Date: Wed, 15 May 2024 12:13:05 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Mike Galbraith <efault@....de>
Cc: mingo@...hat.com, juri.lelli@...hat.com, vincent.guittot@...aro.org,
	dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
	mgorman@...e.de, bristot@...hat.com, vschneid@...hat.com,
	linux-kernel@...r.kernel.org, kprateek.nayak@....com,
	wuyun.abel@...edance.com, tglx@...utronix.de
Subject: Re: [RFC][PATCH 10/10] sched/eevdf: Use sched_attr::sched_runtime to
 set request/slice suggestion

On Tue, May 07, 2024 at 07:34:54AM +0200, Mike Galbraith wrote:
> On Fri, 2024-04-05 at 12:28 +0200, Peter Zijlstra wrote:
> > 
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -7812,7 +7823,9 @@ static int __sched_setscheduler(struct t
> >          * but store a possible modification of reset_on_fork.
> >          */
> >         if (unlikely(policy == p->policy)) {
> > -               if (fair_policy(policy) && attr->sched_nice != task_nice(p))
> > +               if (fair_policy(policy) &&
> > +                   (attr->sched_nice != task_nice(p) ||
> > +                    (attr->sched_runtime && attr->sched_runtime != p->se.slice)))
> >                         goto change;
> 
> Can we make that only look at attr->sched_runtime != p->se.slice? 
> Doing so lets you clear a custom slice by.. clearing it.. rather than
> making tools rummage about for the proper value to overwrite.

Duh yes. Seems I already did the right thing in __setscheduler_params()
for that.

Done.