linux-kernel - Re: [PATCH 5.15 000/168] 5.15.159-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOiWkA8SNRbCPZ_gHQRczZovokZbFSJXQc1vUmtD0quZV9tp0Q@mail.gmail.com>
Date: Tue, 14 May 2024 19:36:24 -0500
From: Martin Faltesek <mfaltesek@...gle.com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, stable@...r.kernel.org, 
	patches@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org, linux@...ck-us.net, 
	shuah@...nel.org, patches@...nelci.org, lkft-triage@...ts.linaro.org, 
	pavel@...x.de, jonathanh@...dia.com, f.fainelli@...il.com, 
	sudipm.mukherjee@...il.com, srw@...dewatkins.net, rwarsow@....de, 
	conor@...nel.org, allen.lkml@...il.com, broonie@...nel.org, 
	Vegard Nossum <vegard.nossum@...cle.com>, Darren Kenny <darren.kenny@...cle.com>
Subject: Re: [PATCH 5.15 000/168] 5.15.159-rc1 review

Build failure on arm:

In file included from drivers/iommu/mtk_iommu_v1.c:22:
drivers/iommu/mtk_iommu_v1.c:579:25: error: 'mtk_iommu_v1_of_ids'
undeclared here (not in a function); did you mean 'mtk_iommu_of_ids'?
  579 | MODULE_DEVICE_TABLE(of, mtk_iommu_v1_of_ids);
      |                         ^~~~~~~~~~~~~~~~~~~
/include/linux/module.h:244:15: note: in definition of macro
'MODULE_DEVICE_TABLE'
  244 | extern typeof(name) __mod_##type##__##name##_device_table
         \
      |               ^~~~
/include/linux/module.h:244:21: error:
'__mod_of__mtk_iommu_v1_of_ids_device_table' aliased to undefined
symbol 'mtk_iommu_v1_of_ids'
  244 | extern typeof(name) __mod_##type##__##name##_device_table
         \
      |                     ^~~~~~
drivers/iommu/mtk_iommu_v1.c:579:1: note: in expansion of macro
'MODULE_DEVICE_TABLE'
  579 | MODULE_DEVICE_TABLE(of, mtk_iommu_v1_of_ids);
      | ^~~~~~~~~~~~~~~~~~~
make[2]: *** [scripts/Makefile.build:289: drivers/iommu/mtk_iommu_v1.o] Error 1
make[1]: *** [scripts/Makefile.build:552: drivers/iommu] Error 2

This is from patch:

bce893a92324  krzk@...nel.org           2024-05-14  iommu: mtk: fix
module autoloading

+MODULE_DEVICE_TABLE(of, mtk_iommu_v1_of_ids);

should be, I think:

+MODULE_DEVICE_TABLE(of, mtk_iommu_of_ids);


On Tue, May 14, 2024 at 11:29 AM Harshit Mogalapalli
<harshit.m.mogalapalli@...cle.com> wrote:
>
> Hi Greg,
>
> On 14/05/24 15:48, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.15.159 release.
> > There are 168 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu, 16 May 2024 10:09:32 +0000.
> > Anything received after that time might be too late.
> >
>
> No problems seen on x86_64 and aarch64 with our testing.
>
> Tested-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
>
> Note: selftests have a build problem in 5.15.y, 5.10.y, 5.4.y, 4.19.y
>
> 5.15.y revert:
> https://lore.kernel.org/all/20240506084635.2942238-1-harshit.m.mogalapalli@oracle.com/
>
> This is not a regression in this tag but from somewhere around 5.15.152 tag.
>
> Reverts for other stable releases:
> 5.10.y:
> https://lore.kernel.org/all/20240506084926.2943076-1-harshit.m.mogalapalli@oracle.com/
> 5.4.y:
> https://lore.kernel.org/all/20240506085044.2943648-1-harshit.m.mogalapalli@oracle.com/
> 4.19.y:
> https://lore.kernel.org/all/20240506105724.3068232-1-harshit.m.mogalapalli@oracle.com/
>
> Could you please queue these up for future releases.
>
>
> Thanks,
> Harshit
> > The whole patch series can be found in one patch at:
> >       https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.159-rc1.gz
> > or in the git tree and branch at:
> >       git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
> >
>