linux-kernel - Re: [PATH net-next 1/2] dt-bindings: net: xilinx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 15 May 2024 16:07:43 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vineeth Karumanchi <vineeth.karumanchi@....com>, git@....com,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 harini.katakam@....com, andrew@...n.ch, hkallweit1@...il.com,
 linux@...linux.org.uk, michal.simek@....com
Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATH net-next 1/2] dt-bindings: net: xilinx_gmii2rgmii: Add
 clock support

On 15/05/2024 11:46, Vineeth Karumanchi wrote:
> Add input clock support to gmii_to_rgmii IP.

Why? Wasn't it there before?

> Add "clocks" and "clock_names" bindings, "clkin" is the input clock name.

Please use standard email subjects, so with the PATCH keyword in the
title. `git format-patch` helps here to create proper versioned patches.
Another useful tool is b4. Skipping the PATCH keyword makes filtering of
emails more difficult thus making the review process less convenient.

Don't write it by yourself....

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

> 
> Signed-off-by: Vineeth Karumanchi <vineeth.karumanchi@....com>
> ---
>  .../devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml      | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml b/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml
> index 0f781dac6717..d84d13fb2c54 100644
> --- a/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml
> +++ b/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml
> @@ -31,6 +31,13 @@ properties:
>    phy-handle:
>      $ref: ethernet-controller.yaml#/properties/phy-handle
>  
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    const: clkin
> +    description: 200/375 MHz free-running clock is used as a input clock.

Nope, just write the description as items in clocks, instead of
maxItems. And drop clock-names, not needed and kind of obvious.

Best regards,
Krzysztof