linux-kernel - Re: [PATCH v5 1/9] dt-bindings: fsi: fsi2spi: Document SPI controller child nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 15 May 2024 16:12:09 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Eddie James <eajames@...ux.ibm.com>, linux-fsi@...ts.ozlabs.org
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, robh@...nel.org, joel@....id.au,
 andrew@...econstruct.com.au
Subject: Re: [PATCH v5 1/9] dt-bindings: fsi: fsi2spi: Document SPI controller
 child nodes

On 15/05/2024 15:06, Eddie James wrote:
> 
> On 5/15/24 03:14, Krzysztof Kozlowski wrote:
>> On 14/05/2024 21:54, Eddie James wrote:
>>
>>>   properties:
>>>     compatible:
>>> @@ -24,6 +23,17 @@ properties:
>>>       items:
>>>         - description: FSI slave address
>>>   
>>> +  "#address-cells":
>>> +    const: 1
>>> +
>>> +  "#size-cells":
>>> +    const: 0
>>> +
>>> +patternProperties:
>>> +  "^spi@[0-9a-f]+$":
>>> +    type: object
>>> +    $ref: /schemas/spi/ibm,spi-fsi.yaml
>> Are you sure you do not have dependencies? Nothing was explained about
>> this in the cover letter or changelog.
> 
> 
> I did mention that it depends on the SPI binding change below the commit 
> message in this patch. I guess I should have kept these two together...

Ah, I missed that. Yeah, you must keep them together or wait one more
cycle... Just test bisectability of your patchset.

Best regards,
Krzysztof