linux-kernel - Re: [PATCH] Convert the Broadcom OTP memory controller to newer DT schema. Created DT schema based on the .txt file which had `compatible`, `reg` `brcm,ocotp-size` as the required properties.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 15 May 2024 16:26:49 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Pratik Farkase <pratikfarkase94@...il.com>
Cc: Pratik Farkase <pratik.farkase@...sweden.com>,
 Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
 Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Convert the Broadcom OTP memory controller to newer DT
 schema. Created DT schema based on the .txt file which had `compatible`,
 `reg` `brcm,ocotp-size` as the required properties.

On 15/05/2024 16:07, Pratik Farkase wrote:
> Signed-off-by: Pratik Farkase <pratik.farkase@...sweden.com>

That's not a proper commit... Read introduction to Git how to create
commits.

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Code itself looked good.

Best regards,
Krzysztof