linux-kernel - Re: [PATCH v3] ext4: Don't reduce symlink i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240515-unbeschadet-wehrlos-64401692a4eb@brauner>
Date: Wed, 15 May 2024 18:49:30 +0200
From: Christian Brauner <brauner@...nel.org>
To: David Howells <dhowells@...hat.com>
Cc: Max Kellermann <max.kellermann@...os.com>, Jan Kara <jack@...e.com>, 
	Miklos Szeredi <miklos@...redi.hu>, linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] ext4: Don't reduce symlink i_mode by umask if no ACL
 support

On Fri, May 10, 2024 at 12:47:21PM +0100, David Howells wrote:
>     
> If CONFIG_EXT4_FS_POSIX_ACL=n then the fallback version of ext4_init_acl()
> will mask off the umask bits from the new inode's i_mode.  This should not
> be done if the inode is a symlink.  If CONFIG_EXT4_FS_POSIX_ACL=y, then we
> go through posix_acl_create() instead which does the right thing with
> symlinks.
> 
> However, this is actually unnecessary now as vfs_prepare_mode() has already
> done this where appropriate, so fix this by making the fallback version of
> ext4_init_acl() do nothing.
> 
> Fixes: 484fd6c1de13 ("ext4: apply umask if ACL support is disabled")
> Suggested-by: Miklos Szeredi <miklos@...redi.hu>
> Signed-off-by: David Howells <dhowells@...hat.com>
> cc: Max Kellermann <max.kellermann@...os.com>
> cc: Jan Kara <jack@...e.com>
> cc: Christian Brauner <brauner@...nel.org>
> cc: linux-ext4@...r.kernel.org
> cc: linux-fsdevel@...r.kernel.org
> ---

Reviewed-by: Christian Brauner <brauner@...nel.org>