linux-kernel - Re: [PATCH v6 2/2] platform/x86: dell-laptop: Implement platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <2419538f-199c-4404-9af4-e17259e09cf4@app.fastmail.com>
Date: Wed, 15 May 2024 11:06:43 -0600
From: "Lyndon Sanche" <lsanche@...deno.ca>
To: "Armin Wolf" <W_Armin@....de>
Cc: "Mario Limonciello" <mario.limonciello@....com>,
 Pali Rohár <pali@...nel.org>,
 srinivas.pandruvada@...ux.intel.com,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 "kernel test robot" <lkp@...el.com>, "Hans de Goede" <hdegoede@...hat.com>,
 "Yijun Shen" <Yijun.Shen@...l.com>, "Matthew Garrett" <mjg59@...f.ucam.org>,
 "Heiner Kallweit" <hkallweit1@...il.com>,
 "Randy Dunlap" <rdunlap@...radead.org>, "Jonathan Corbet" <corbet@....net>,
 "Vegard Nossum" <vegard.nossum@...cle.com>,
 platform-driver-x86@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Dell.Client.Kernel@...l.com
Subject: Re: [PATCH v6 2/2] platform/x86: dell-laptop: Implement platform_profile



On Sun, May 12, 2024, at 12:05 PM, Armin Wolf wrote:
> Am 11.05.24 um 04:36 schrieb Lyndon Sanche:
>

>> +static int thermal_init(void)
>> +{
>> +	int ret;
>> +	int supported_modes;
>> +
>> +	/* If thermal commands not supported, exit without error */
>> +	if (!dell_laptop_check_supported_cmds(CLASS_INFO))
>> +		return 0;
>> +
>> +	/* If thermal modes not supported, exit without error */
>> +	ret = thermal_get_supported_modes(&supported_modes);
>> +	if (ret < 0)
>> +		return ret;
>
> Hi,
>
> the function dell_smbios_error() says that when a specific functionality is
> not supported, -ENXIO is returned.
>
> Please treat this as "no thermal modes supported", since checking if CLASS_INFO
> is supported is not enough (CLASS_INFO is also used by other functionality like
> rfkill, so machines might support CLASS_INFO but not USTT).
>
> Thanks,
> Armin Wolf
>

Armin:

Thank you for this. I will include this in the next revision.

Thanks,

Lyndon