linux-kernel - Re: [PATCH v3] x86/tools: fix line number reported for malformed lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 15 May 2024 20:17:16 +0200
From: Valentin Obst <kernel@...entinobst.de>
To: mhiramat@...nel.org
Cc: a.hindborg@...sung.com,
	bp@...en8.de,
	dave.hansen@...ux.intel.com,
	gregkh@...uxfoundation.org,
	hpa@...or.com,
	john.m.baublitz@...il.com,
	kernel@...entinobst.de,
	linux-kernel@...r.kernel.org,
	mingo@...nel.org,
	mingo@...hat.com,
	ojeda@...nel.org,
	peterz@...radead.org,
	sergio.collado@...il.com,
	stable@...r.kernel.org,
	tglx@...utronix.de,
	x86@...nel.org
Subject: Re: [PATCH v3] x86/tools: fix line number reported for malformed lines

> > Commit 35039eb6b199 ("x86: Show symbol name if insn decoder test failed")
> > included symbol lines in the post-processed objdump output consumed by
> > the insn decoder test. This broke the `instuction lines == total lines`
> > property that `insn_decoder_test.c` relied upon to print the offending
> > line's number in error messages. This has the consequence that the line
> > number reported on a test failure is unreated to, and much smaller than,
> > the line that actually caused the problem.
> >
> > Add a new variable that counts the combined (insn+symbol) line count and
> > report this in the error message.
>
> This looks good to me. Thanks!
>
> Acked-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>

Thanks!

So what is the status on this one? Is there someone here who can take it
through their tree s.t. it might make it into 6.10-rc1 or 6.11-rc1?

	- Best Valentin

>
> >
> > Fixes: 35039eb6b199 ("x86: Show symbol name if insn decoder test failed")
> > Cc: stable@...r.kernel.org
> > Reviewed-by: Miguel Ojeda <ojeda@...nel.org>
> > Tested-by: Miguel Ojeda <ojeda@...nel.org>
> > Reported-by: John Baublitz <john.m.baublitz@...il.com>
> > Debugged-by: John Baublitz <john.m.baublitz@...il.com>
> > Signed-off-by: Valentin Obst <kernel@...entinobst.de>
>
> --
> Masami Hiramatsu (Google) <mhiramat@...nel.org>