linux-kernel - Re: [PATCH v4 45/66] selftests/proc: Drop define _GNU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4bbc6001-bafe-4db9-83fe-e03ddce1eb26@p183>
Date: Thu, 16 May 2024 22:05:42 +0300
From: Alexey Dobriyan <adobriyan@...il.com>
To: Edward Liaw <edliaw@...gle.com>
Cc: Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 45/66] selftests/proc: Drop define _GNU_SOURCE

> --- a/tools/testing/selftests/proc/proc-empty-vm.c
> +++ b/tools/testing/selftests/proc/proc-empty-vm.c

> -#undef _GNU_SOURCE
> -#define _GNU_SOURCE

No! Don't do this. It makes individual test program non-standalone.

Right now you can copy it to some other machine which triggers test
fauilure, compile and start debugging instead of remembering which
stupid compile flags it requires.

NAK for /proc, sorry. I'd like to keep #define.