linux-kernel - RE: [PATCH v4 1/3] scsi: ufs: Allow RTT negotiation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 16 May 2024 23:56:21 +0000
From: Avri Altman <Avri.Altman@....com>
To: Bart Van Assche <bvanassche@....org>, "Martin K . Petersen"
	<martin.petersen@...cle.com>
CC: Bean Huo <beanhuo@...ron.com>, Peter Wang <peter.wang@...iatek.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v4 1/3] scsi: ufs: Allow RTT negotiation

> On 5/16/24 09:21, Avri Altman wrote:
> >> On 5/15/24 23:51, Avri Altman wrote:
> >>>    void ufshcd_fixup_dev_quirks(struct ufs_hba *hba,
> >>>                             const struct ufs_dev_quirk *fixups)
> >>>    {
> >>> @@ -8278,6 +8312,8 @@ static int ufs_get_device_desc(struct ufs_hba
> *hba)
> >>>        if (hba->ext_iid_sup)
> >>>                ufshcd_ext_iid_probe(hba, desc_buf);
> >>>
> >>> +     ufshcd_rtt_set(hba, desc_buf);
> >>> +
> >>
> >> Why does this call occur in ufs_get_device_desc()? ufshcd_rtt_set()
> >> sets a device parameter. Shouldn't this call be moved one level up
> >> into ufshcd_device_params_init()?
> > Because otherwise bDeviceRTTCap is not available.
> > Please note several device configuration calls in  ufs_get_device_desc - all
> requires some device descriptor fields.
> 
> Please make sure that the functionality of ufs_get_device_desc() and the name of
> that function remain in sync.
> 
> I think that bDeviceRTTCap is available in ufshcd_device_params_init() after
> ufs_get_device_desc() has returned?
Will make the required change.

Thanks,
Avri

> 
> Thanks,
> 
> Bart.