[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5aa68ee5-dd84-4ac2-9fd1-36160358fdcf@molgen.mpg.de>
Date: Thu, 16 May 2024 07:44:44 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Oliver Neukum <oneukum@...e.com>, marcel@...tmann.org,
luiz.dentz@...il.com, linux-bluetooth@...r.kernel.org,
linux-kernel@...r.kernel.org, Kiran K <kiran.k@...el.com>
Subject: Re: [PATCH] bluetooth: btintel_pcie: nonsense error recording in irq
[Cc: +Kiran]
Dear Oliver,
Thank you for the patch. I have two minor comments. Could you please
word the summary as a statement by adding a verb (in imperative mood).
Maybe:
> Fix nonsense …
or
> Remove unused `ret` assignment
Am 16.05.24 um 06:50 schrieb Oliver Neukum:
> Either you return an error or you ignore it.
> Recording it but then overwriting it makes no sense.
It’d be great if you added a Fixes: tag.
> Signed-off-by: Oliver Neukum <oneukum@...e.com>
> ---
> drivers/bluetooth/btintel_pcie.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
> index 590c188a4bb3..c507422d6b1b 100644
> --- a/drivers/bluetooth/btintel_pcie.c
> +++ b/drivers/bluetooth/btintel_pcie.c
> @@ -498,19 +498,15 @@ static int btintel_pcie_submit_rx_work(struct btintel_pcie_data *data, u8 status
> rfh_hdr = buf;
>
> len = rfh_hdr->packet_len;
> - if (len <= 0) {
> - ret = -EINVAL;
> + if (len <= 0)
> goto resubmit;
> - }
>
> /* Remove RFH header */
> buf += sizeof(*rfh_hdr);
>
> skb = alloc_skb(len, GFP_ATOMIC);
> - if (!skb) {
> - ret = -ENOMEM;
> + if (!skb)
> goto resubmit;
> - }
>
> skb_put_data(skb, buf, len);
> skb_queue_tail(&data->rx_skb_q, skb);
Kind regards,
Paul
Powered by blists - more mailing lists