linux-kernel - Re: [PATCH 3/8] dma-buf: heaps: Import uAPI header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb65e783-4d01-46c3-8e9e-de40811dafd2@amd.com>
Date: Thu, 16 May 2024 10:14:18 +0200
From: Christian König <christian.koenig@....com>
To: Maxime Ripard <mripard@...nel.org>, Rob Herring <robh@...nel.org>,
 Saravana Kannan <saravanak@...gle.com>,
 Sumit Semwal <sumit.semwal@...aro.org>,
 Benjamin Gaignard <benjamin.gaignard@...labora.com>,
 Brian Starkey <Brian.Starkey@....com>, John Stultz <jstultz@...gle.com>,
 "T.J. Mercier" <tjmercier@...gle.com>
Cc: Mattijs Korpershoek <mkorpershoek@...libre.com>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linaro-mm-sig@...ts.linaro.org
Subject: Re: [PATCH 3/8] dma-buf: heaps: Import uAPI header

Am 15.05.24 um 15:56 schrieb Maxime Ripard:
> The uAPI header has a bunch of constants and structures that might be
> handy in drivers.
>
> Let's include the header in the driver-side dma-heap header.

Well as long as this header doesn't need any symbols from the uAPI 
itself I think that is a no-go.

Includes should only be applied for things which are really necessary 
and not because some driver might need it.

Regards,
Christian.

>
> Signed-off-by: Maxime Ripard <mripard@...nel.org>
> ---
>   include/linux/dma-heap.h | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/dma-heap.h b/include/linux/dma-heap.h
> index 0c05561cad6e..e7cf110c5fdc 100644
> --- a/include/linux/dma-heap.h
> +++ b/include/linux/dma-heap.h
> @@ -10,10 +10,12 @@
>   #define _DMA_HEAPS_H
>   
>   #include <linux/cdev.h>
>   #include <linux/types.h>
>   
> +#include <uapi/linux/dma-heap.h>
> +
>   struct dma_heap;
>   
>   /**
>    * struct dma_heap_ops - ops to operate on a given heap
>    * @allocate:		allocate dmabuf and return struct dma_buf ptr
>