linux-kernel - Re: drivers/net/dsa/dsa_loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 16 May 2024 10:27:49 +0100
From: Stephen Langstaff <stephenlangstaff1@...il.com>
To: Florian Fainelli <f.fainelli@...il.com>
Cc: Andrew Lunn <andrew@...n.ch>, linux-kernel@...r.kernel.org, OlteanV@...il.com
Subject: Re: drivers/net/dsa/dsa_loop_bdinfo.c build problems

On Wed, May 15, 2024 at 8:27 PM Florian Fainelli <f.fainelli@...il.com> wrote:
> What changes have you done to the dsa_loop.c file for this error to show
> up? Currently the driver does the following:
>
> static void dsa_loop_phylink_get_caps(struct dsa_switch *dsa, int port,
>                                          struct phylink_config *config)
>    {
>            bitmap_fill(config->supported_interfaces,
> PHY_INTERFACE_MODE_MAX);
>            __clear_bit(PHY_INTERFACE_MODE_NA, config->supported_interfaces);
>            config->mac_capabilities = ~0;
>    }
>
> which is basically to say: I support everything, except
> PHY_INTERFACE_MDOE_NA.

I am currently on kernel version 6.1.55 which does not appear to have
this caps code in, and neither does 6.1.90.

The following commit to net/dsa/port.c, backported to the 6.1 tree,
appears to fix the issue
https://github.com/torvalds/linux/commit/9945c1fb03a3c9f7e0dcf9aa17041a70e551387a

Steve.