linux-kernel - Re: [PATCH 0/3] parport: Cleanup some pre-devmodel code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZkXj9Ip3DoUAe1wt@gallifrey>
Date: Thu, 16 May 2024 10:46:12 +0000
From: "Dr. David Alan Gilbert" <dave@...blig.org>
To: sudipm.mukherjee@...il.com
Cc: arnd@...db.de, linux-kernel@...r.kernel.org,
	linux-parport@...ts.infradead.org
Subject: Re: [PATCH 0/3] parport: Cleanup some pre-devmodel code

* linux@...blig.org (linux@...blig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> There are some remenants of the pre-devmodel code
> still in the parport drivers; try and clean some of them out.

Ping!

Dave

> This series should have no visible change, all the drivers
> already use the devmodel, it's just removing the flags
> that say that, and cleaning out no longer used function pointers.
> (To me the most useful bit is removing the no longer used
> 'attach' pointer, so if you've got code that's trying to use
> it you'll get educated).
> 
> Trivially tested in qemu, I can still write to the lp;
> 
> Also checked with grep -r 'struct parport_driver' . -A 9
> to see if I've missed any.
> 
> (I found this while dragging the out-of-tree ppscsi code
> into working on head, so that I could use my prehistoric
> HP PP scanner)
> 
> Dave
> 
> Dr. David Alan Gilbert (3):
>   parport: Remove 'drivers' list
>   parport: Remove attach function pointer
>   parport: Remove parport_driver.devmodel
> 
>  drivers/ata/pata_parport/pata_parport.c  | 1 -
>  drivers/auxdisplay/ks0108.c              | 1 -
>  drivers/auxdisplay/panel.c               | 1 -
>  drivers/char/lp.c                        | 1 -
>  drivers/char/ppdev.c                     | 1 -
>  drivers/i2c/busses/i2c-parport.c         | 1 -
>  drivers/input/joystick/db9.c             | 1 -
>  drivers/input/joystick/gamecon.c         | 1 -
>  drivers/input/joystick/turbografx.c      | 1 -
>  drivers/input/joystick/walkera0701.c     | 1 -
>  drivers/input/serio/parkbd.c             | 1 -
>  drivers/net/hamradio/baycom_epp.c        | 1 -
>  drivers/net/hamradio/baycom_par.c        | 1 -
>  drivers/net/plip/plip.c                  | 1 -
>  drivers/parport/daisy.c                  | 1 -
>  drivers/parport/share.c                  | 9 ---------
>  drivers/pps/clients/pps_parport.c        | 1 -
>  drivers/pps/generators/pps_gen_parport.c | 1 -
>  drivers/scsi/imm.c                       | 1 -
>  drivers/scsi/ppa.c                       | 1 -
>  drivers/spi/spi-butterfly.c              | 1 -
>  drivers/spi/spi-lm70llp.c                | 1 -
>  include/linux/parport.h                  | 6 ------
>  sound/drivers/mts64.c                    | 1 -
>  sound/drivers/portman2x4.c               | 1 -
>  25 files changed, 38 deletions(-)
> 
> -- 
> 2.44.0
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/