linux-kernel - Re: [PATCH 1/3] regulator: don't cache vsel to ensure voltage setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 16 May 2024 12:33:36 +0100
From: Mark Brown <broonie@...nel.org>
To: Matti Vaittinen <mazziesaccount@...il.com>
Cc: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
	Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] regulator: don't cache vsel to ensure voltage setting

On Thu, May 16, 2024 at 11:53:46AM +0300, Matti Vaittinen wrote:

> +		/*
> +		 * Some PMICs treat the vsel_reg same as apply-bit. Force it
> +		 * to be written even if the old selector were same as the new
> +		 * (but range changed) by using regmap_write_bits() and not the
> +		 * regmap_update_bits().
> +		 */
> +		ret = regmap_write_bits(rdev->regmap, rdev->desc->vsel_reg,
> +					rdev->desc->vsel_mask, sel);

This feels like a special case for those devices, for devices that don't
have this behaviour it'd be a regression in that it'd increase I/O
traffic.  At least this should be specialised to only devices that have
ranges I think?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)