linux-kernel - Re: [PATCH] blk-cgroup: Properly propagate the iostat update up the hierarchy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <171582607425.11025.1197820625337989209.b4-ty@kernel.dk>
Date: Wed, 15 May 2024 20:21:14 -0600
From: Jens Axboe <axboe@...nel.dk>
To: Tejun Heo <tj@...nel.org>, Josef Bacik <josef@...icpanda.com>, 
 Waiman Long <longman@...hat.com>
Cc: cgroups@...r.kernel.org, linux-block@...r.kernel.org, 
 linux-kernel@...r.kernel.org, Dan Schatzberg <schatzberg.dan@...il.com>, 
 Ming Lei <ming.lei@...hat.com>
Subject: Re: [PATCH] blk-cgroup: Properly propagate the iostat update up
 the hierarchy


On Wed, 15 May 2024 10:30:59 -0400, Waiman Long wrote:
> During a cgroup_rstat_flush() call, the lowest level of nodes are flushed
> first before their parents. Since commit 3b8cc6298724 ("blk-cgroup:
> Optimize blkcg_rstat_flush()"), iostat propagation was still done to
> the parent. Grandparent, however, may not get the iostat update if the
> parent has no blkg_iostat_set queued in its lhead lockless list.
> 
> Fix this iostat propagation problem by queuing the parent's global
> blkg->iostat into one of its percpu lockless lists to make sure that
> the delta will always be propagated up to the grandparent and so on
> toward the root blkcg.
> 
> [...]

Applied, thanks!

[1/1] blk-cgroup: Properly propagate the iostat update up the hierarchy
      commit: 9d230c09964e6e18c8f6e4f0d41ee90eef45ec1c

Best regards,
-- 
Jens Axboe