linux-kernel - Re: [PATCH v4 1/3] scsi: ufs: Allow RTT negotiation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91e9322b-9304-4cb7-a1be-1f43208800e8@acm.org>
Date: Thu, 16 May 2024 08:28:18 -0600
From: Bart Van Assche <bvanassche@....org>
To: Avri Altman <avri.altman@....com>,
 "Martin K . Petersen" <martin.petersen@...cle.com>
Cc: Bean Huo <beanhuo@...ron.com>, Peter Wang <peter.wang@...iatek.com>,
 linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/3] scsi: ufs: Allow RTT negotiation

On 5/15/24 23:51, Avri Altman wrote:
>   void ufshcd_fixup_dev_quirks(struct ufs_hba *hba,
>   			     const struct ufs_dev_quirk *fixups)
>   {
> @@ -8278,6 +8312,8 @@ static int ufs_get_device_desc(struct ufs_hba *hba)
>   	if (hba->ext_iid_sup)
>   		ufshcd_ext_iid_probe(hba, desc_buf);
>   
> +	ufshcd_rtt_set(hba, desc_buf);
> +

Why does this call occur in ufs_get_device_desc()? ufshcd_rtt_set() sets
a device parameter. Shouldn't this call be moved one level up into
ufshcd_device_params_init()?

Otherwise this patch looks good to me.

Thanks,

Bart.