[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZkYdDtoPMnYlGT/6@lizhi-Precision-Tower-5810>
Date: Thu, 16 May 2024 10:49:50 -0400
From: Frank Li <Frank.li@....com>
To: linux@...blig.org
Cc: vkoul@...nel.org, linux-arm-msm@...r.kernel.org,
dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: qcom: gpi: remove unused struct 'gpi_desc'
On Thu, May 16, 2024 at 02:32:11PM +0100, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>
> 'gpi_desc' seems like it was never used.
> Remove it.
code change show 'reg_info', not 'gpi_desc'. You need make sure that it
really is not used, not "seems like".
'struct reg_info' is never used, so remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> ---
> drivers/dma/qcom/gpi.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
> index 1c93864e0e4d..639ab304db9b 100644
> --- a/drivers/dma/qcom/gpi.c
> +++ b/drivers/dma/qcom/gpi.c
> @@ -476,12 +476,6 @@ struct gpi_dev {
> struct gpii *gpiis;
> };
>
> -struct reg_info {
> - char *name;
> - u32 offset;
> - u32 val;
> -};
> -
> struct gchan {
> struct virt_dma_chan vc;
> u32 chid;
> --
> 2.45.0
>
Powered by blists - more mailing lists