linux-kernel - Re: [PATCH] gpio: prevent potential speculation leaks in gpio_device_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240516162239.GA184911@rigel>
Date: Fri, 17 May 2024 00:22:39 +0800
From: Kent Gibson <warthog618@...il.com>
To: Hagar Hemdan <hagarhem@...zon.com>
Cc: Norbert Manthey <nmanthey@...zon.de>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: prevent potential speculation leaks in
 gpio_device_get_desc()

On Thu, May 16, 2024 at 10:55:40PM +0800, Kent Gibson wrote:
> On Thu, May 16, 2024 at 12:57:42PM +0000, Hagar Hemdan wrote:
> > On Tue, May 14, 2024 at 08:42:21PM +0800, Kent Gibson wrote:
>
> Now I need to test your patch to see what it actually does.
>

Tested.  Fails.  It does what I thought it would - clamps the offset into
bounds BEFORE the call to gpio_device_get_desc().

The appropriate place for this fix is in gpio_device_get_desc(), after
the bounds check.

Cheers,
Kent.