linux-kernel - Re: [PATCH] drm/etnaviv: drop driver owner assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 16 May 2024 19:13:06 +0200
From: Lucas Stach <l.stach@...gutronix.de>
To: Christian Gmeiner <christian.gmeiner@...il.com>, Krzysztof Kozlowski
	 <krzysztof.kozlowski@...aro.org>
Cc: Russell King <linux+etnaviv@...linux.org.uk>, David Airlie
	 <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, 
	etnaviv@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/etnaviv: drop driver owner assignment

Am Montag, dem 01.04.2024 um 12:26 +0200 schrieb Christian Gmeiner:
> > 
> > Core in platform_driver_register() already sets the .owner, so driver
> > does not need to.  Whatever is set here will be anyway overwritten by
> > main driver calling platform_driver_register().
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> Reviewed-by: Christian Gmeiner <cgmeiner@...lia.com>

Applied to the etnaviv/next branch.

Regards,
Lucas

> 
> > ---
> >  drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> > index 734412aae94d..87b31cfee41d 100644
> > --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> > @@ -1995,7 +1995,6 @@ static const struct dev_pm_ops etnaviv_gpu_pm_ops = {
> >  struct platform_driver etnaviv_gpu_driver = {
> >         .driver = {
> >                 .name = "etnaviv-gpu",
> > -               .owner = THIS_MODULE,
> >                 .pm = pm_ptr(&etnaviv_gpu_pm_ops),
> >                 .of_match_table = etnaviv_gpu_match,
> >         },
> > --
> > 2.34.1
> > 
> 
>