linux-kernel - Re: [PATCH] x86/efistub: Omit physical KASLR when memory reservations exist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXG1TLKR1ukg7Vn3rgAC2opL1LN6EX9L9XVxZQ3s+6wuBQ@mail.gmail.com>
Date: Thu, 16 May 2024 19:30:47 +0200
From: Ard Biesheuvel <ardb@...nel.org>
To: "Chaney, Ben" <bchaney@...mai.com>
Cc: Ard Biesheuvel <ardb+git@...gle.com>, 
	"linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>, "keescook@...omium.org" <keescook@...omium.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "x86@...nel.org" <x86@...nel.org>, 
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH] x86/efistub: Omit physical KASLR when memory reservations exist

On Thu, 16 May 2024 at 19:29, Chaney, Ben <bchaney@...mai.com> wrote:
>
> > +static efi_status_t parse_options(const char *cmdline)
> > +{
> > + static const char opts[][14] = {
> > + "mem=", "memmap=", "efi_fake_mem=", "hugepages="
> > + };
> > +
>
> I think we probably want to include both crashkernel and pstore as arguments that can disable this randomization.
>

The existing code in arch/x86/boot/compressed/kaslr.c currently does
not take these into account, as far as I can tell.