linux-kernel - Re: [PULL 17/19] KVM: SEV: Provide support for SNP_GUEST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58492a1a-63bb-47d2-afef-164557d15261@redhat.com>
Date: Sat, 18 May 2024 00:01:05 +0200
From: Paolo Bonzini <pbonzini@...hat.com>
To: "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>,
 "michael.roth@....com" <michael.roth@....com>
Cc: "aik@....com" <aik@....com>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
 "ashish.kalra@....com" <ashish.kalra@....com>,
 "thomas.lendacky@....com" <thomas.lendacky@....com>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "seanjc@...gle.com" <seanjc@...gle.com>,
 "brijesh.singh@....com" <brijesh.singh@....com>
Subject: Re: [PULL 17/19] KVM: SEV: Provide support for SNP_GUEST_REQUEST NAE
 event

On 5/17/24 22:41, Edgecombe, Rick P wrote:
> I get a build error in kvm-coco-queue with W=1:
> 
> arch/x86/kvm/svm/sev.c: In function ‘__snp_handle_guest_req’:
> arch/x86/kvm/svm/sev.c:3968:30: error: variable ‘sev’ set but not used [-
> Werror=unused-but-set-variable]
>   3968 |         struct kvm_sev_info *sev;
>        |                              ^~~
> cc1: all warnings being treated as errors
> 
> To fix it:
> 
> diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
> index 57c2c8025547..6beaa6d42de9 100644
> --- a/arch/x86/kvm/svm/sev.c
> +++ b/arch/x86/kvm/svm/sev.c
> @@ -3965,14 +3965,11 @@ static int __snp_handle_guest_req(struct kvm *kvm, gpa_t
> req_gpa, gpa_t resp_gpa
>                                    sev_ret_code *fw_err)
>   {
>          struct sev_data_snp_guest_request data = {0};
> -       struct kvm_sev_info *sev;
>          int ret;
>   
>          if (!sev_snp_guest(kvm))
>                  return -EINVAL;
>   
> -       sev = &to_kvm_svm(kvm)->sev_info;
> -
>          ret = snp_setup_guest_buf(kvm, &data, req_gpa, resp_gpa);
>          if (ret)
>                  return ret;

I'll post a fully updated version tomorrow with all the pending fixes. 
Or today depending on the timezone.

Paolo