linux-kernel - Re: [PATCH] arm64: dts: mt7622: fix switch probe on bananapi-r64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5AEE5668-0C8E-4EE4-A398-66CB99DF5650@public-files.de>
Date: Fri, 17 May 2024 08:27:24 +0200
From: Frank Wunderlich <frank-w@...lic-files.de>
To: Arınç ÜNAL <arinc.unal@...nc9.com>,
 Frank Wunderlich <linux@...web.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
CC: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 Daniel Golle <daniel@...rotopia.org>
Subject: Re: [PATCH] arm64: dts: mt7622: fix switch probe on bananapi-r64

Am 17. Mai 2024 04:17:47 MESZ schrieb "Arınç ÜNAL" <arinc.unal@...nc9.com>:
>On 16/05/2024 23:48, Frank Wunderlich wrote:
>> From: Frank Wunderlich <frank-w@...lic-files.de>
>> 
>> After commit 868ff5f4944a
>> ("net: dsa: mt7530-mdio: read PHY address of switch from device tree")
>> the mt7531 switch on Bananapi-R64 was not detected.
>> 
>> mt7530-mdio mdio-bus:00: reset timeout
>> mt7530-mdio mdio-bus:00: probe with driver mt7530-mdio failed with error -110
>> 
>> Fix this by adding phy address in devicetree.
>> 
>> Signed-off-by: Frank Wunderlich <frank-w@...lic-files.de>
>
>I don't like the mention of the Linux kernel driver on the patch log. What
>you're fixing is the incorrect description of the switch's PHY address on
>the DTS file. Whether or not any driver from any project is actually
>reading it from the DTS file is irrelevant to this patch. That said, I
>already have a patch series I've been meaning to send the next version of
>that already addresses this. Please wait for that.
>
>Arınç

Hi arinc,

From my PoV it is a regression in next/6.10 because the driver change was merged (without "broadcast" fallback) and the dts patch [1] is not.

I agree that my patch can be dropped because there was already one.

regards Frank

[1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20240314-for-mediatek-mt7531-phy-address-v1-1-52f58db01acd@arinc9.com/