[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID:
<AS4PR04MB96921A132C1F767792609323E7EE2@AS4PR04MB9692.eurprd04.prod.outlook.com>
Date: Fri, 17 May 2024 07:17:56 +0000
From: Neeraj Sanjay Kale <neeraj.sanjaykale@....com>
To: Neeraj Sanjay Kale <neeraj.sanjaykale@....com>, "marcel@...tmann.org"
<marcel@...tmann.org>, "luiz.dentz@...il.com" <luiz.dentz@...il.com>
CC: "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Amitkumar
Karwar <amitkumar.karwar@....com>, Rohit Fule <rohit.fule@....com>, Sherry
Sun <sherry.sun@....com>, Luke Wang <ziniu.wang_1@....com>, Bough Chen
<haibo.chen@....com>, LnxRevLi <LnxRevLi@....com>
Subject: RE: [PATCH v2] Bluetooth: btnxpuart: Enable Power Save feature on
startup
Hi Luiz,
If no further reviews, can we merge this?
Thanks,
Neeraj
> This sets the default power save mode setting to enabled.
>
> The power save feature is now stable and stress test issues, such as the TX
> timeout error, have been resolved.
> commit c7ee0bc8db32 ("Bluetooth: btnxpuart: Resolve TX timeout error in
> power save stress test")
>
> With this setting, the driver will send the vendor command to FW at startup,
> to enable power save feature.
>
> User can disable this feature using the following vendor command:
> hcitool cmd 3f 23 03 00 00 (HCI_NXP_AUTO_SLEEP_MODE)
>
> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@....com>
> Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>
> ---
> v2: Corrected subject line. Added commit reference. (Paul Menzel)
> drivers/bluetooth/btnxpuart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c
> index 7f88b6f52f26..42e929f0d141 100644
> --- a/drivers/bluetooth/btnxpuart.c
> +++ b/drivers/bluetooth/btnxpuart.c
> @@ -281,7 +281,7 @@ static u8 crc8_table[CRC8_TABLE_SIZE];
>
> /* Default configurations */
> #define DEFAULT_H2C_WAKEUP_MODE WAKEUP_METHOD_BREAK
> -#define DEFAULT_PS_MODE PS_MODE_DISABLE
> +#define DEFAULT_PS_MODE PS_MODE_ENABLE
> #define FW_INIT_BAUDRATE HCI_NXP_PRI_BAUDRATE
>
> static struct sk_buff *nxp_drv_send_cmd(struct hci_dev *hdev, u16 opcode,
> --
> 2.34.1
Powered by blists - more mailing lists