linux-kernel - Re: [PATCH v2] dmaengine: qcom: gpi: remove unused struct 'reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 17 May 2024 11:19:03 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Cc: Frank.li@....com, vkoul@...nel.org, linux-arm-msm@...r.kernel.org,
	dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dmaengine: qcom: gpi: remove unused struct 'reg_info'

* Dr. David Alan Gilbert (linux@...blig.org) wrote:
> * Bryan O'Donoghue (bryan.odonoghue@...aro.org) wrote:
> > On 16/05/2024 17:25, linux@...blig.org wrote:
> > > From: "Dr. David Alan Gilbert" <linux@...blig.org>
> > > 
> > > Remove unused struct 'reg_info'
> > > 
> > > Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> > > ---
> > >   drivers/dma/qcom/gpi.c | 6 ------
> > >   1 file changed, 6 deletions(-)
> > > 
> > > diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
> > > index 1c93864e0e4d..639ab304db9b 100644
> > > --- a/drivers/dma/qcom/gpi.c
> > > +++ b/drivers/dma/qcom/gpi.c
> > > @@ -476,12 +476,6 @@ struct gpi_dev {
> > >   	struct gpii *gpiis;
> > >   };
> > > -struct reg_info {
> > > -	char *name;
> > > -	u32 offset;
> > > -	u32 val;
> > > -};
> > > -
> > >   struct gchan {
> > >   	struct virt_dma_chan vc;
> > >   	u32 chid;
> 
> Hi Bryan,
> 
> > More detail in the commit log please - is the structure unused ? What is the
> > provenance of it being added and becoming dead code.
> > 
> > More detail required here.
> 
> If you look at the V1 I had
> ''gpi_desc' seems like it was never used.
> Remove it.'
> 
> but Frank suggested copying the subject line; so I'm not sure
> whether you want more or less!
> 
> I could change this to:
> 
> 'gpi_desc' was never used since it's initial
> commit 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver")

Oops, of course I mean 'reg_info' which is what I fixed in v2.

> Would you be OK with that?

Dave

> Dave
> 
> 
> > 
> > ---
> > bod
> > 
> -- 
>  -----Open up your eyes, open up your mind, open up your code -------   
> / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
> \        dave @ treblig.org |                               | In Hex /
>  \ _________________________|_____ http://www.treblig.org   |_______/
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/