linux-kernel - Re: [PATCH] net: Fix the gso BUG_ON that treat the skb which head_frag is true as non head

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <66464991ac8ea_54e932947a@willemb.c.googlers.com.notmuch>
Date: Fri, 17 May 2024 22:02:51 +0800
From: Fred Li <dracodingfly@...il.com>
To: willemdebruijn.kernel@...il.com,
	dracoding <dracodingfly@...il.com>,
	davem@...emloft.net,
	kuba@...nel.org,
	ast@...nel.org,
	daniel@...earbox.net,
	andrii@...nel.org,
	kafai@...com,
	songliubraving@...com,
	yhs@...com,
	john.fastabend@...il.com,
	kpsingh@...nel.org
Cc: bpf@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net: Fix the gso BUG_ON that treat the skb which head_frag is true as non head_frag

From: Willem de Bruijn <willemdebruijn.kernel@...il.com>

> dracoding wrote:
> > From: Fred Li <dracodingfly@...il.com>
> > 
> > The crashed kernel version is 5.16.20, and I have not test this patch
> > because I dont find a way to reproduce it, and the mailine may be
> > has the same problem.
> 
> That is a pretty old kernel.
> 
> There has been work in this space in the meantime. Such as commit
> 3dcbdb134f32 ("net: gso: Fix skb_segment splat when splitting gso_size
> mangled skb having linear-headed frag_list") or commit 9e4b7a99a03a
> ("net: gso: fix panic on frag_list with mixed head alloc types").

The mainline kernel is using the commit 9e4b7a99a03a("net: gso: fix panic
on frag_list with mixed head alloc types") version, but it not work for me.
It disable NETIF_F_SG only if it has non head_frag skb. This case is it has
only one head_frag frag_list skb. I will send a test case which will cause 
the system crash, also in a newest kernel 6.6.8.