linux-kernel - RE: [PATCH v1] ARM: dts: aspeed: yosemite4: add I3C config in DTS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 17 May 2024 02:35:51 +0000
From: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@...ynn.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Delphine_CC_Chiu/WYHQ/Wiwynn
	<Delphine_CC_Chiu@...ynn.com>, "patrick@...cx.xyz" <patrick@...cx.xyz>,
	"joel@....id.au" <joel@....id.au>, "openbmc@...ts.ozlabs.org"
	<openbmc@...ts.ozlabs.org>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Andrew
 Jeffery <andrew@...econstruct.com.au>
CC: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v1] ARM: dts: aspeed: yosemite4: add I3C config in DTS



> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Monday, May 6, 2024 11:38 PM
> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@...ynn.com>;
> patrick@...cx.xyz; joel@....id.au; openbmc@...ts.ozlabs.org; Rob Herring
> <robh@...nel.org>; Krzysztof Kozlowski <krzk+dt@...nel.org>; Conor Dooley
> <conor+dt@...nel.org>; Andrew Jeffery <andrew@...econstruct.com.au>
> Cc: devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> linux-aspeed@...ts.ozlabs.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v1] ARM: dts: aspeed: yosemite4: add I3C config in DTS
> 
>   Security Reminder: Please be aware that this email is sent by an external
> sender.
> 
> On 06/05/2024 13:33, Delphine CC Chiu wrote:
> > Set I3C config in yosemite4 DTS.
> >
> > Test plan:
> > Tested with aspeed I3C patches and I3C hub driver.
> >
> > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>
> > ---
> >  .../aspeed/aspeed-bmc-facebook-yosemite4.dts  | 86
> +++++++++++++++++++
> >  1 file changed, 86 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> > index 64075cc41d92..6a30c424d745 100644
> > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> > @@ -595,6 +595,92 @@ i2c-mux@72 {
> >       };
> >  };
> >
> > +&i3c0 {
> > +     status = "okay";
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_i3c1_default>;
> > +     i3c-pp-scl-hi-period-ns = <40>;
> > +     i3c-pp-scl-lo-period-ns = <40>;
> > +     i3c-od-scl-hi-period-ns = <380>;
> > +     i3c-od-scl-lo-period-ns = <620>;
> > +     sda-tx-hold-ns = <10>;
> > +
> > +     mctp-controller;
> > +     hub@...0 {
> 
> That's not a valid unit address.
> 
> 
Will update in the next patch. Thanks.

> > +             reg = <0x70 0x3c0 0x00700000>;
> > +             cp0-ldo-en = "enabled";
> > +             cp1-ldo-en = "enabled";
> > +             cp0-ldo-volt = "1.2V";
> > +             cp1-ldo-volt = "1.2V";
> > +             tp0145-ldo-en = "enabled";
> > +             tp2367-ldo-en = "enabled";
> > +             tp0145-ldo-volt = "1.2V";
> > +             tp2367-ldo-volt = "1.2V";
> > +             tp0145-pullup = "2k";
> > +             tp2367-pullup = "2k";
> 
> Where are bindings for all this?
> 
The bindings are from the following binding document.
https://patchwork.kernel.org/project/linux-i3c/patch/20240217131412.4145506-1-steven.niu.uj@renesas.com/