linux-kernel - Re: [PATCH 04/13] a2b: add AD24xx I2C interface driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <iyxpcmz5okfzvplla4glmuqsoky4cd6fv7orhsgqjepvdrivnp@63z64jwlsks4>
Date: Fri, 17 May 2024 16:49:20 +0200
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Alvin Šipraga <alvin@...s.dk>
Cc: Mark Brown <broonie@...nel.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Linus Walleij <linus.walleij@...aro.org>, 
	Bartosz Golaszewski <brgl@...ev.pl>, Liam Girdwood <lgirdwood@...il.com>, 
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, 
	Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, 
	Andi Shyti <andi.shyti@...nel.org>, Saravana Kannan <saravanak@...gle.com>, 
	Emil Svendsen <emas@...g-olufsen.dk>, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-gpio@...r.kernel.org, linux-sound@...r.kernel.org, linux-clk@...r.kernel.org, 
	linux-i2c@...r.kernel.org, Alvin Šipraga <alsi@...g-olufsen.dk>
Subject: Re: [PATCH 04/13] a2b: add AD24xx I2C interface driver


> +	/*
> +	 * Enforce some basic assumptions this function makes about the
> +	 * transfer. If this proves insufficient, some more complex logic will
> +	 * be needed.
> +	 */
> +	if (num > 2 || (num == 2 && msgs[0].addr != msgs[1].addr))
> +		return -EOPNOTSUPP;

As you populated 'ad24xx_i2c_adapter_quirks' in the I2C driver, you can
drop this. The I2C core will do the checks for you.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)