linux-kernel - Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADnq5_MnsAEk_YsyMjaDH6G406E4=hQvMtOTU5xh5JeZJE7kqw@mail.gmail.com>
Date: Fri, 17 May 2024 16:15:26 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Tim Van Patten <timvp@...omium.org>
Cc: Christian König <christian.koenig@....com>, 
	LKML <linux-kernel@...r.kernel.org>, alexander.deucher@....com, 
	prathyushi.nangia@....com, Tim Van Patten <timvp@...gle.com>, 
	Daniel Vetter <daniel@...ll.ch>, David Airlie <airlied@...il.com>, 
	Felix Kuehling <Felix.Kuehling@....com>, Ikshwaku Chauhan <ikshwaku.chauhan@....com>, Le Ma <le.ma@....com>, 
	Lijo Lazar <lijo.lazar@....com>, Mario Limonciello <mario.limonciello@....com>, 
	"Pan, Xinhui" <Xinhui.Pan@....com>, "Shaoyun.liu" <Shaoyun.liu@....com>, 
	Shiwu Zhang <shiwu.zhang@....com>, Srinivasan Shanmugam <srinivasan.shanmugam@....com>, 
	amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

On Fri, May 17, 2024 at 1:27 PM Tim Van Patten <timvp@...omium.org> wrote:
>
> > Fair enough, but this is also the only gfx9 APU which defaults to
> > noretry=1, all of the rest are dGPUs.  I'd argue it should align with
> > the other GFX9 APUs or they should all enable noretry=1.
>
> Do you mean we should remove all IP_VERSION(9, X, X) entries from
> amdgpu_gmc_noretry_set(), leaving just >= IP_VERSION(10, 3, 0)?

No, just take your patch as is.  All of the other 9.x IP versions in
that check are dGPUs.  9.3.0 was the only APU in that list.

Alex