linux-kernel - Re: [PATCH] KVM: SEV: Fix unused variable in guest request handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <83b2db44-c7bc-49af-8634-d349b91dfab0@gmail.com>
Date: Sat, 18 May 2024 10:29:03 -0500
From: Carlos Bilbao <carlos.bilbao.osdev@...il.com>
To: Michael Roth <michael.roth@....com>, kvm@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, Paolo Bonzini <pbonzini@...hat.com>,
 linux-coco@...ts.linux.dev, Sean Christopherson <seanjc@...gle.com>
Subject: Re: [PATCH] KVM: SEV: Fix unused variable in guest request handling

On 5/13/24 13:19, Michael Roth wrote:

> The variable 'sev' is assigned, but never used. Remove it.
>
> Fixes: 449ead2d1edb ("KVM: SEV: Provide support for SNP_GUEST_REQUEST NAE event")
> Signed-off-by: Michael Roth <michael.roth@....com>


Reviewed-by: Carlos Bilbao <carlos.bilbao.osdev@...il.com>


> ---
>  arch/x86/kvm/svm/sev.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
> index 59c0d89a4d52..6cf665c410b2 100644
> --- a/arch/x86/kvm/svm/sev.c
> +++ b/arch/x86/kvm/svm/sev.c
> @@ -3965,14 +3965,11 @@ static int __snp_handle_guest_req(struct kvm *kvm, gpa_t req_gpa, gpa_t resp_gpa
>  				  sev_ret_code *fw_err)
>  {
>  	struct sev_data_snp_guest_request data = {0};
> -	struct kvm_sev_info *sev;
>  	int ret;
>  
>  	if (!sev_snp_guest(kvm))
>  		return -EINVAL;
>  
> -	sev = &to_kvm_svm(kvm)->sev_info;
> -
>  	ret = snp_setup_guest_buf(kvm, &data, req_gpa, resp_gpa);
>  	if (ret)
>  		return ret;