linux-kernel - Re: [PATCH v1] dt-bindings: pwm: describe the cells in #pwm-cells in pwm.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <oan6mlql2co4jsmnh3ghbomakdphab352fyq3plupellevkvly@f3jhiwidtkv3>
Date: Sat, 18 May 2024 23:49:36 +0200
From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To: Conor Dooley <conor@...nel.org>
Cc: linux-pwm@...r.kernel.org, Conor Dooley <conor.dooley@...rochip.com>, 
	Chris Packham <Chris.Packham@...iedtelesis.co.nz>, Guenter Roeck <linux@...ck-us.net>, 
	Uwe Kleine-König <ukleinek@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] dt-bindings: pwm: describe the cells in #pwm-cells in
 pwm.yaml

On Fri, May 17, 2024 at 06:38:46PM +0100, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@...rochip.com>
> 
> When commit 89650a1e3b6f ("dt-bindings: pwm: Convert PWM bindings
> to json-schema") converted the pwm provider section of the text binding
> to dt-schema it also updated all references to pwm.txt in pwm provider
> bindings to pwm.yaml.
> 
> Most pwm provider bindings had a reference to pwm.txt as it contains a
> description of what the cells in #pwm-cells are, albeit in the consumer
> section of the document. Only information in the provider section of the
> document was moved to the yaml binding, and it contains no information
> about the cell format, making all references to it for the cell format
> unhelpful.
> 
> Fixes: 89650a1e3b6f ("dt-bindings: pwm: Convert PWM bindings to json-schema")
> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> ---
> 
> I yoinked the wording from pwm.txt. Having "Typically" feels a bit
> clumsy, but a given provider is free to override that order AFAIU.

All drivers that have 3 cells use that order, some drivers use less and
skip different values.

The patch looks fine, thanks. Will apply it after the merge window.

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)