linux-kernel - Re: [RFC PATCH net-next 23/28] net: ethernet: ti: cpsw-proxy-client: add sw tx/rx irq coalescing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d7edd9b-f11c-4b8d-a63c-cecb104aa91c@web.de>
Date: Sun, 19 May 2024 16:12:27 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Siddharth Vadapalli <s-vadapalli@...com>, netdev@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, kernel-janitors@...r.kernel.org,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Jonathan Corbet <corbet@....net>,
 MD Danish Anwar <danishanwar@...com>, Paolo Abeni <pabeni@...hat.com>,
 Roger Quadros <rogerq@...nel.org>, Vladimir Oltean <vladimir.oltean@....com>
Cc: LKML <linux-kernel@...r.kernel.org>, linux-doc@...r.kernel.org,
 Misael Lopez Cruz <misael.lopez@...com>, Sriramakrishnan <srk@...com>,
 Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [RFC PATCH net-next 23/28] net: ethernet: ti: cpsw-proxy-client:
 add sw tx/rx irq coalescing

…
> +++ b/drivers/net/ethernet/ti/cpsw-proxy-client.c
…
> @@ -996,8 +1001,15 @@ static int vport_tx_poll(struct napi_struct *napi_tx, int budget)
…
> +		if (unlikely(tx_chn->tx_pace_timeout && !tdown)) {
> +			hrtimer_start(&tx_chn->tx_hrtimer,
> +				      ns_to_ktime(tx_chn->tx_pace_timeout),
> +				      HRTIMER_MODE_REL_PINNED);
> +		} else {
> +			enable_irq(tx_chn->irq);
> +		}
…
> @@ -1179,12 +1191,38 @@ static int vport_rx_poll(struct napi_struct *napi_rx, int budget)
…
> +			if (unlikely(rx_chn->rx_pace_timeout)) {
> +				hrtimer_start(&rx_chn->rx_hrtimer,
> +					      ns_to_ktime(rx_chn->rx_pace_timeout),
> +					      HRTIMER_MODE_REL_PINNED);
> +			} else {
> +				enable_irq(rx_chn->irq);
> +			}
…

Would you like to omit curly brackets at a few source code places?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.9#n197

Regards,
Markus