linux-kernel - Re: [PATCH v2 7/9] iio: adc: ad7173: Remove index from temp channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 19 May 2024 18:08:51 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: dumitru.ceclan@...log.com, Lars-Peter Clausen <lars@...afoo.de>, Michael
 Hennerich <Michael.Hennerich@...log.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, Dumitru Ceclan
 <mitrutzceclan@...il.com>
Subject: Re: [PATCH v2 7/9] iio: adc: ad7173: Remove index from temp channel

On Wed, 15 May 2024 18:34:17 -0500
David Lechner <dlechner@...libre.com> wrote:

> On Tue, May 14, 2024 at 2:23 AM Dumitru Ceclan via B4 Relay
> <devnull+dumitru.ceclan.analog.com@...nel.org> wrote:
> >
> > From: Dumitru Ceclan <dumitru.ceclan@...log.com>
> >
> > Temperature channel is unique per device, index is not needed.
> >
> > This is breaking userspace: as main driver has not reached mainline yet
> > it won't affect users as there are none.  
> 
> But it is queued up, so probably need a Fixes: here to make sure it
> makes it into the release.
Yes. We can fix this but it will need to go as a fix during the rc cycles
rather than wait for the next merge window like the rest of this series.

Jonathan



> 
> >
> > Signed-off-by: Dumitru Ceclan <dumitru.ceclan@...log.com>
> > ---
> >  drivers/iio/adc/ad7173.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> > index d965b66d4d5a..d66b47e1a186 100644
> > --- a/drivers/iio/adc/ad7173.c
> > +++ b/drivers/iio/adc/ad7173.c
> > @@ -828,7 +828,6 @@ static const struct iio_chan_spec ad7173_channel_template = {
> >
> >  static const struct iio_chan_spec ad7173_temp_iio_channel_template = {
> >         .type = IIO_TEMP,
> > -       .indexed = 1,
> >         .channel = AD7173_AIN_TEMP_POS,
> >         .channel2 = AD7173_AIN_TEMP_NEG,
> >         .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |
> >
> > --
> > 2.43.0
> >
> >