[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240519184523.03794b53@jic23-huawei>
Date: Sun, 19 May 2024 18:45:23 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Alisa-Dariana Roman <alisadariana@...il.com>
Cc: michael.hennerich@...log.com, linux-iio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, lars@...afoo.de,
robh@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
lgirdwood@...il.com, broonie@...nel.org, andy@...nel.org,
nuno.sa@...log.com, marcelo.schmitt@...log.com, bigunclemax@...il.com,
dlechner@...libre.com, okan.sahin@...log.com, fr0st61te@...il.com,
alisa.roman@...log.com, marcus.folkesson@...il.com, schnelle@...ux.ibm.com,
liambeguin@...il.com
Subject: Re: [PATCH v8 1/6] iio: adc: ad7192: Use standard attribute
On Tue, 14 May 2024 15:02:17 +0300
Alisa-Dariana Roman <alisadariana@...il.com> wrote:
> Replace custom attribute filter_low_pass_3db_frequency_available with
> standard attribute.
>
> Store the available values in ad7192_state struct.
>
> The function that used to compute those values replaced by
> ad7192_update_filter_freq_avail().
>
> Function ad7192_show_filter_avail() is no longer needed.
>
> Note that the initial available values are hardcoded.
>
> Also moved the mutex lock and unlock in order to protect the whole
> switch statement since each branch modifies the state of the device.
>
> Reviewed-by: David Lechner <dlechner@...libre.com>
> Signed-off-by: Alisa-Dariana Roman <alisa.roman@...log.com>
I'm going to work my way through these, picking things up until I
hit anything that needs non trivial changes (hopefully I won't!)
Applied
Powered by blists - more mailing lists