linux-kernel - Re: [PATCH v3 9/9] drivers: iio: imu: Add support for adis1657x family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 19 May 2024 19:38:05 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: kernel test robot <lkp@...el.com>
Cc: Ramona Gradinariu <ramona.bolboaca13@...il.com>,
 linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, conor+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, robh@...nel.org, nuno.sa@...log.com,
 oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH v3 9/9] drivers: iio: imu: Add support for adis1657x
 family

On Sat, 18 May 2024 14:47:01 +0800
kernel test robot <lkp@...el.com> wrote:

> Hi Ramona,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on jic23-iio/togreg]
> [cannot apply to linus/master v6.9 next-20240517]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Ramona-Gradinariu/dt-bindings-iio-imu-Add-ADIS16501-compatibles/20240517-155051
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
> patch link:    https://lore.kernel.org/r/20240517074750.87376-10-ramona.bolboaca13%40gmail.com
> patch subject: [PATCH v3 9/9] drivers: iio: imu: Add support for adis1657x family
> config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240518/202405181400.174vWAhr-lkp@intel.com/config)
> compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240518/202405181400.174vWAhr-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202405181400.174vWAhr-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers/iio/imu/adis16475.c:523:9: error: initialization of 'const struct iio_dev_attr *' from incompatible pointer type 'struct attribute *' [-Werror=incompatible-pointer-types]  
>      523 |         &iio_dev_attr_hwfifo_watermark_min.dev_attr.attr,
>          |         ^
>    drivers/iio/imu/adis16475.c:523:9: note: (near initialization for 'adis16475_fifo_attributes[0]')
>    drivers/iio/imu/adis16475.c:524:9: error: initialization of 'const struct iio_dev_attr *' from incompatible pointer type 'struct attribute *' [-Werror=incompatible-pointer-types]
>      524 |         &iio_dev_attr_hwfifo_watermark_max.dev_attr.attr,
>          |         ^
>    drivers/iio/imu/adis16475.c:524:9: note: (near initialization for 'adis16475_fifo_attributes[1]')
>    drivers/iio/imu/adis16475.c:525:9: error: initialization of 'const struct iio_dev_attr *' from incompatible pointer type 'struct attribute *' [-Werror=incompatible-pointer-types]
>      525 |         &iio_dev_attr_hwfifo_watermark.dev_attr.attr,
>          |         ^
>    drivers/iio/imu/adis16475.c:525:9: note: (near initialization for 'adis16475_fifo_attributes[2]')
>    drivers/iio/imu/adis16475.c:526:9: error: initialization of 'const struct iio_dev_attr *' from incompatible pointer type 'struct attribute *' [-Werror=incompatible-pointer-types]
>      526 |         &iio_dev_attr_hwfifo_enabled.dev_attr.attr,
>          |         ^
>    drivers/iio/imu/adis16475.c:526:9: note: (near initialization for 'adis16475_fifo_attributes[3]')
>    cc1: some warnings being treated as errors
> 
> 
> vim +523 drivers/iio/imu/adis16475.c
> 
>    514	
>    515	static IIO_DEVICE_ATTR_RO(hwfifo_watermark_min, 0);
>    516	static IIO_DEVICE_ATTR_RO(hwfifo_watermark_max, 0);
>    517	static IIO_DEVICE_ATTR(hwfifo_watermark, 0444,
>    518			       adis16475_get_fifo_watermark, NULL, 0);
>    519	static IIO_DEVICE_ATTR(hwfifo_enabled, 0444,
>    520			       adis16475_get_fifo_enabled, NULL, 0);
>    521	
>    522	static const struct iio_dev_attr *adis16475_fifo_attributes[] = {
>  > 523		&iio_dev_attr_hwfifo_watermark_min.dev_attr.attr,  
>    524		&iio_dev_attr_hwfifo_watermark_max.dev_attr.attr,
>    525		&iio_dev_attr_hwfifo_watermark.dev_attr.attr,
>    526		&iio_dev_attr_hwfifo_enabled.dev_attr.attr,
>    527		NULL
>    528	};
drop the dev_attr.attr parts.  This will 'work' because they are all at the start of
the containing structure, but it should be the iio_dev_attrs as in a similar
case here:
https://elixir.bootlin.com/linux/latest/source/drivers/iio/accel/adxl372.c#L1009

>    529	
>