linux-kernel - Re: [PATCH] ufs: mcq: Fix missing argument 'hba' in MCQ_OPR_OFFSET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZkpjaHaGOWMZ++di@localhost>
Date: Mon, 20 May 2024 05:39:04 +0900
From: Minwoo Im <minwoo.im@...sung.com>
To: Bart Van Assche <bvanassche@....org>
Cc: "James E . J . Bottomley" <James.Bottomley@...senpartnership.com>,
	"Martin K . Petersen" <martin.petersen@...cle.com>, Alim Akhtar
	<alim.akhtar@...sung.com>, Avri Altman <avri.altman@....com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, Joel Granados
	<j.granados@...sung.com>, gost.dev@...sung.com, Asutosh Das
	<quic_asutoshd@...cinc.com>, Minwoo Im <minwoo.im@...sung.com>
Subject: Re: [PATCH] ufs: mcq: Fix missing argument 'hba' in
 MCQ_OPR_OFFSET_n

On 24-05-16 08:03:17, Bart Van Assche wrote:
> On 5/15/24 21:14, Minwoo Im wrote:
> >   /* Operation and runtime registers configuration */
> >   #define MCQ_CFG_n(r, i)	((r) + MCQ_QCFG_SIZE * (i))
> > -#define MCQ_OPR_OFFSET_n(p, i) \
> > +#define MCQ_OPR_OFFSET_n(hba, p, i) \
> >   	(hba->mcq_opr[(p)].offset + hba->mcq_opr[(p)].stride * (i))
> Since inline functions are preferred over macros, please convert the
> MCQ_OPR_OFFSET_n() macro into an inline function.

Okay.  I will prepare v2.

> 
> Thanks,
> 
> Bart.
>