| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 19 May 2024 09:15:19 +0200 From: Markus Elfring <Markus.Elfring@....de> To: Alvin Šipraga <alsi@...g-olufsen.dk>, devicetree@...r.kernel.org, linux-sound@...r.kernel.org, linux-i2c@...r.kernel.org, linux-gpio@...r.kernel.org, linux-clk@...r.kernel.org, kernel-janitors@...r.kernel.org Cc: LKML <linux-kernel@...r.kernel.org>, Alvin Šipraga <alvin@...s.dk>, Emil Svendsen <emas@...g-olufsen.dk>, Andi Shyti <andi.shyti@...nel.org>, Bartosz Golaszewski <brgl@...ev.pl>, Conor Dooley <conor+dt@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jaroslav Kysela <perex@...ex.cz>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Liam Girdwood <lgirdwood@...il.com>, Linus Walleij <linus.walleij@...aro.org>, Mark Brown <broonie@...nel.org>, Michael Turquette <mturquette@...libre.com>, "Rafael J. Wysocki" <rafael@...nel.org>, Rob Herring <robh@...nel.org>, Saravana Kannan <saravanak@...gle.com>, Stephen Boyd <sboyd@...nel.org>, Takashi Iwai <tiwai@...e.com> Subject: Re: [PATCH 01/13] a2b: add A2B driver core … > +++ b/drivers/a2b/a2b.c > @@ -0,0 +1,1252 @@ … > +#define __a2b_bus_for_each_node(__bus, __node, __i) \ > + for (__i = 0; __i < A2B_MAX_NODES && (__node = __bus->nodes[__i]); i++) … I suggest to reconsider the usage of double underscores for identifiers. How do you think about to avoid that this software depends on undefined behaviour? https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier Regards, Markus
Powered by blists - more mailing lists