linux-kernel - Re: [PATCH 01/13] a2b: add A2B driver core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b546e80f-b07e-4c29-a856-1db347939cd6@web.de>
Date: Sun, 19 May 2024 13:18:46 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Alvin Šipraga <alsi@...g-olufsen.dk>,
 devicetree@...r.kernel.org, linux-sound@...r.kernel.org,
 linux-i2c@...r.kernel.org, linux-gpio@...r.kernel.org,
 linux-clk@...r.kernel.org, kernel-janitors@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Alvin Šipraga
 <alvin@...s.dk>, Emil Svendsen <emas@...g-olufsen.dk>,
 Andi Shyti <andi.shyti@...nel.org>, Bartosz Golaszewski <brgl@...ev.pl>,
 Conor Dooley <conor+dt@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jaroslav Kysela <perex@...ex.cz>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Liam Girdwood <lgirdwood@...il.com>, Linus Walleij
 <linus.walleij@...aro.org>, Mark Brown <broonie@...nel.org>,
 Michael Turquette <mturquette@...libre.com>,
 "Rafael J. Wysocki" <rafael@...nel.org>, Rob Herring <robh@...nel.org>,
 Saravana Kannan <saravanak@...gle.com>, Stephen Boyd <sboyd@...nel.org>,
 Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH 01/13] a2b: add A2B driver core

…
> +++ b/drivers/a2b/a2b.c
> @@ -0,0 +1,1252 @@
…
> +static int a2b_node_uevent(const struct device *dev,
> +			   struct kobj_uevent_env *env)
> +{
…
> +		if (add_uevent_var(env, "A2B_NODE_VENDOR=%02x", node->vendor))
> +			return -ENOMEM;
…
> +		if (add_uevent_var(env, "A2B_NODE_VERSION=%02x", node->version))
> +			return -ENOMEM;
…

I suggest to merge three if statements into one in a branch of
this function implementation.

Regards,
Markus